👽️(frontend) Generate typescript api client - winter 2023 #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
5 times, most recently
from
29a7c08
to
bb4c252
Compare
rlecellier
commented
Nov 21, 2023
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
from
bb4c252
to
450cef9
Compare
rlecellier
commented
Nov 21, 2023
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
from
450cef9
to
7c6fe4a
Compare
rlecellier
commented
Nov 22, 2023
|
|
||
| import type { Address } from './Address'; | ||
|
|
||
| export type PaginatedAddressList = { |
There was a problem hiding this comment.
doc: https://drf-spectacular.readthedocs.io/en/latest/faq.html#how-do-i-wrap-my-responses-my-endpoints-are-wrapped-in-a-generic-envelope
todo: try to use spectacular envelope in order to create a PaginatedSerialier
todo: try to use envelope into a custom pagination class https://www.django-rest-framework.org/api-guide/pagination/#custom-pagination-styles
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
from
7c6fe4a
to
eecbfe5
Compare
rlecellier
commented
Feb 28, 2024
| page?: number, | ||
| pageSize?: number, | ||
| productId?: string, | ||
| signatureState?: 'half_signed' | 'signed' | 'unsigned', |
There was a problem hiding this comment.
It would be nice to have :
enum SignatureStateEnum {
half_signed,
signed,
unsigned
}
// ...
signatureState?: SignatureStateEnum
a46fe84
to
1a38c6f
Compare
We'll implement a api client generated from joanie's openApi schema. The current client needs to change place.
We'll implement a api client generated from joanie's openApi schema. The current client's type factories needs to change place.
Add openapi-typescript-codegen@0.23.0 to the projet this lib handle typescript api client generation from openapi schema
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
5 times, most recently
from
fcd2806
to
2d3a4c2
Compare
Generate typescript api client according to joanie openapi schema
on CoursesService and OrganizationService, a function get the id param twice.
Generated api client need's to handle joanie authentification
use generated Address type instead of legacy one
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
2 times, most recently
from
7125685
to
4781687
Compare
rlecellier
requested review from
NathanVss and
jbpenrath
and removed request for
NathanVss
now that we've generated types and api client, we need to use them into our api hooks
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
2 times, most recently
from
9efc67a
to
abefe25
Compare
Joanie's api client shouldn't be loaded on test that don't use it.
rlecellier
force-pushed
the
rlecellier/generated_api_2023
branch
from
abefe25
to
3da710e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Here the generated typescript client with the current joanie's openapi schema
TODO: